Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename in_cluster_url to internal_url; rename url to external_url #820

Merged
merged 1 commit into from
Sep 23, 2024
Merged

rename in_cluster_url to internal_url; rename url to external_url #820

merged 1 commit into from
Sep 23, 2024

Conversation

jmazzitelli
Copy link
Contributor

@jmazzitelli jmazzitelli added the requires server PR A PR requires additional changes in the backend code. label Sep 18, 2024
@jmazzitelli jmazzitelli self-assigned this Sep 18, 2024
@jmazzitelli jmazzitelli mentioned this pull request Sep 18, 2024
Closed
@jmazzitelli
Copy link
Contributor Author

molecule tests pass:

=====================
=== TEST RESULTS: ===
=====================

                            grafana-test... success [3m 11s]
                             jaeger-test... success [2m 23s]
                     null-cr-values-test... success [1m 35s]

@jmazzitelli jmazzitelli marked this pull request as ready for review September 18, 2024 21:46
@jmazzitelli jmazzitelli mentioned this pull request Sep 18, 2024
Merged
@jmazzitelli jmazzitelli force-pushed the 7745-rename-url-settings branch from 1927c74 to 51909bc Compare September 23, 2024 12:24
@josunect josunect self-requested a review September 23, 2024 14:09
josunect
josunect approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@josunect josunect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with kiali/kiali#7759, LGTM

@jmazzitelli jmazzitelli merged commit d7d771d into kiali:master Sep 23, 2024
1 check passed
@jmazzitelli jmazzitelli deleted the 7745-rename-url-settings branch September 23, 2024 16:01
@jshaughn jshaughn added the test: molecule Molecule test infrastructure and tests themselves label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josunect josunect josunect approved these changes

Assignees

@jmazzitelli jmazzitelli

Labels
requires server PR A PR requires additional changes in the backend code. test: molecule Molecule test infrastructure and tests themselves
Projects
Kiali Sprint 24-16 | Kiali v2.3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmazzitelli @josunect @jshaughn