Description of kiali_urls. Kiali URL to cluster name mapping.

[hhovsepy]

Issue kiali/kiali#6243

[hhovsepy]

Server PR kiali/kiali#6452

[jmazzitelli]

LGTM

[nrfox]

Never mind these settings are used by the operator/helm-chart but are not part of the kiali config @hhovsepy can you also remove these settings as they are no longer present in the kiali server config and no longer valid:

                      autodetect_secrets:
                        description: "Settings to allow cluster secrets to be auto-detected. Secrets must exist in the Kiali deployment namespace."
                        type: object
                        properties:
                          enabled:
                            description: "If true then remote cluster secrets will be autodetected during the installation of the Kiali Server Deployment. Any remote cluster secrets found in the Kiali deployment namespace will be mounted to the Kiali Server's file system. If false, you can still manually specify the remote cluster secret information in the 'clusters' setting if you wish to utilize multicluster features."
                            type: boolean
                          label:
                            description: "The name and value of a label that exists on all remote cluster secrets. Default is 'kiali.io/multiCluster=true'."
                            type: string
                      clusters:
                        description: "A list of clusters that the Kiali Server can access. You need to specify the remote clusters here if 'autodetect_secrets.enabled' is false."
                        type: array
                        items:
                          type: object
                          properties:
                            name:
                              description: "The name of the cluster."
                              type: string
                            secret_name:
                              description: "The name of the secret that contains the credentials necessary to connect to the remote cluster. This secret must exist in the Kiali deployment namespace."
                              type: string

[nrfox]

It looks like they're present in the helm chart as well: https://github.com/kiali/helm-charts/blob/master/kiali-server/values.yaml#L96-L100

[jmazzitelli]

can you also remove these settings as they are no longer present in the kiali server config and no longer valid

no, these are very important. This is how the operator (and helm charts) sets up the kiali remote cluster secrets. don't remove these :)

kiali-operator/roles/default/kiali-deploy/tasks/main.yml

Lines 722 to 736 in 8038592

	- name: Autodetect remote cluster secrets within the Kiali deployment namespace
	vars:
	all_remote_cluster_secrets: "{{ query(k8s_plugin, namespace=kiali_vars.deployment.namespace, api_version='v1', kind='Secret', label_selector=kiali_vars.kiali_feature_flags.clustering.autodetect_secrets.label) }}"
	loop: "{{ all_remote_cluster_secrets }}"
	set_fact:
	kiali_deployment_remote_cluster_secret_volumes: "{{ kiali_deployment_remote_cluster_secret_volumes | combine({ item.metadata.annotations['kiali.io/cluster']|default(item.metadata.name): {'secret_name': item.metadata.name }}) }}"
	when:
	- kiali_vars.kiali_feature_flags.clustering.autodetect_secrets.enabled
	- name: Prepare the manually declared remote clusters
	loop: "{{ kiali_vars.kiali_feature_flags.clustering.clusters }}"
	set_fact:
	kiali_deployment_remote_cluster_secret_volumes: "{{ kiali_deployment_remote_cluster_secret_volumes | combine({ item.name: {'secret_name': item.secret_name }}) }}"
	when:
	- kiali_vars.kiali_feature_flags.clustering.clusters | length > 0

kiali-operator/roles/default/kiali-deploy/templates/openshift/deployment.yaml

Lines 125 to 129 in 8038592

	{% for sec in kiali_deployment_remote_cluster_secret_volumes %}
	- name: {{ sec }}
	mountPath: "/kiali-remote-cluster-secrets/{{ kiali_deployment_remote_cluster_secret_volumes[sec].secret_name }}"
	readOnly: true
	{% endfor %}

[jmazzitelli]

they are no longer present in the kiali server config

We actually don't put them in the Kiali Config object because they aren't used by the server at all - these are one of the few settings that are for the operator (and helm charts) only - i.e. used only for installation. The Server never uses these settings so that is why they aren't in the Config object.

[nrfox]

We actually don't put them in the Kiali Config object because they aren't used by the server at all - these are one of the few settings that are for the operator (and helm charts) only - i.e. used only for installation. The Server never uses these settings so that is why they aren't in the Config object.

Ah alright that makes sense. I'm always unsure of which configuration on the CR is just for the operator and which is for the kiali config.

[jmazzitelli]

I'm always unsure of which configuration on the CR is just for the operator and which is for the kiali config.

This is why I try to always make the Config object match the CR - only because its confusing if they don't match ("why is this in the CR but not in the Config object?").

I actually went against my instincts when I did not include these secret/cluster settings in the Config object. I convinced myself it was the right thing to do because these settings are essentially useless to the server - the server should never have a reason to look up their values.

[nrfox]

This is why I try to always make the Config object match the CR - only because its confusing if they don't match ("why is this in the CR but not in the Config object?").

Well if there's ever a Kiali v2 with some breaking changes, perhaps we can separate the two on the CR. Something like

  spec:
    kialiConfig: ...
    deployment: ...
    otherCRFieldNotRelatedToConfig: ...