Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some improvements, some refactor #263

Merged
merged 30 commits into from
Feb 10, 2024
Merged

Some improvements, some refactor #263

merged 30 commits into from
Feb 10, 2024

Conversation

boholder
Copy link
Collaborator

@boholder boholder commented Feb 6, 2024 •
edited
Loading

Pull Request Checklist

- [ ] A new fragment is added in ./doc/news that describes what is new (refer to issue #174).

Describe what you have changed in this PR

Feature Changes

  • Now the Read Crosshair feature will only play the position sound cue once when player looks at different sides of same block.
  • When locking on an entity, POI Locking feature will always try to target at a valid position that you can interact with, thus you can attack a monster even it expose small part of its body to you.
  • Now POI Locking feature will never let you make eye contact with an Enderman.
  • Boat, mine cart, slime, magma cube, and ancient debris can be scanned and locked with POI feature now. #157 #203 #215

Bug Fixes

  • Fix the bug that looking at fluid will make Read Crosshair spam. #262

And some refactor.
With khanshoaib3/minecraft-access-i18n#32

Will release these changes as 1.5.3.

@boholder
Try to fix the problem that link message for platform changelog isn't…
550b3b0 
… being correctly pasted
@boholder
Let POIMarking passes marked target to POIBlocks and POIEntities
d18928a
@boholder
Simplify block scan init in POIBlocks
89a0a95
@boholder
Make player can look at Entity even the entity exposes a small part o…
63670bd 
…f its body
@boholder
HashSet has index, so it's better than ArrayList at comparing
db1fe70
@boholder
Fix the bug that looking at fluid will make Read Crosshair spam
5066e12 
close khanshoaib3#262
@boholder
Revert PlayerUtils.isInFluid method
304de9f
@boholder
Unify fluid/crosshair hit result and block/fluid narration through ut…
ebbf7fe 
…il methods
@boholder
Add narration for waterlogged blocks
46bc682
@boholder
Read Crosshair only play the position sound cue once when player look…
7a359d8 
…s at different sides of same block
@boholder
Never look at Enderman's face
6dd3b15
@boholder
Expose vertical facing direction speaking
72c5146
@boholder
Update mod version to 1.5.3
6d7db03
@boholder boholder added the 1.20 Minecraft 1.20.* version label Feb 6, 2024
@boholder boholder changed the title Refactor poi Some improvements, some refactor Feb 6, 2024
@boholder
Remove Optional wrapper from return values of WorldUtils
c4eb805 
Since we invoke them only when player is in game, the Optional wrapper serves no value
@boholder
Make setMarked... methods be private
f14931f
@boholder
Move recursion invokes ahead to reduce values in each call stack
72731c0
@boholder
Simplify block position values
22763b6
@boholder
Extract block sound playing method
1ed1e57
@boholder
Remove annoying IDE null checking
5bc1c31
@boholder
Extract block checking method
52e774b
@boholder
Move play sound condition into its method
ef58261 
it's better to let that method has this knowledge
@boholder
Air block is not a valid POI block, so return early
5909701
@boholder
Rearrange POI Marking handling logic in POIBlocks
167da99 
close khanshoaib3#231
@boholder
Remove client param in playSound method
20f8c6b
@boholder
Add boat and mine cart into POIEntities
a6e021f 
close khanshoaib3#157
@boholder
Return reasonable POI scanned target lists
c7a84fe
@boholder
All mine cart sound are too noisy to use as POI sound cue
3c4355d
@boholder
Add ancient debris into POIBlocks
3d8b668 
close khanshoaib3#215
@khanshoaib3 khanshoaib3 merged commit fdf9274 into khanshoaib3:1.20 Feb 10, 2024
2 checks passed
@boholder boholder deleted the refactor-poi branch February 25, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanshoaib3 khanshoaib3 khanshoaib3 approved these changes

Assignees
No one assigned
Labels
1.20 Minecraft 1.20.* version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boholder @khanshoaib3