Mainly refactor LockingHandler #233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And remove every-position log
of getBlockAndFluidTargetInformation and getBlockAndFluidTargetPosition
…tick is more simple
maybe we can utilize it in the future, far future when developing new features
so we can use it to save accurate position (Vec3d) and use it as BlockPos type (extended from Vec 3i)
…change, in manual
…nder original `PlayerUtils` into it
to fit logic of lockOnEntity method
|
There is a NPE thrown bug! |
|
Won't open until #234 is fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
- [ ] A new fragment is added in./doc/newsthat describes what is new (refer to issue #174).Describe what you have changed in this PR
Refactor here and there for #232
Each commit is small enough to be understand quickly.
There is a config name change, with khanshoaib3/minecraft-access-i18n#30