Fix triggers for gradcorrect and archives #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jobs that passed keyword arguments were failing (e.g. subject_labels={1,
2, 3}) as it wouldn't know how to handle these in the decorator. This
just adds **kwargs to allow for passing of keyword arguments.
There was a bug with the previous implementation, where if a study had a custom ria url (which is any study valid study), gradcorrect would not be triggered (for 7T studies). This commit / PR fixes this bug such that it gradcorrect will be triggered if the study exists or if there is a custom ria url.
Change logic such that archiving is not triggered if study cannot be found (i.e. `study.custom_ria_url is None`)
kaitj
added
the
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic was not triggering
gradcorrectand archiving of datasets. This PR fixes this and also updates the help message for each CLI task.