Attachment Improvements #90
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khakers
added
enhancement
|
No longer targeted to v1. |
khakers
force-pushed
the
feature/attachment-improvements
branch
from
17c0903
to
22ad879
Compare
Adds attachment cards for all non-media (image/video) type attachments. Moves videos into
… grid In the future it would be nice to add some logic to the image grid like how discord does it. It would likely require a lightbox which doesn't work properly at the moment.
Integrates Glightbox into thread images and videos. Disables pointer events on spoilered image Reformats the CSP headers declaration and adds some inline styles that glightbox uses as well as discord cdn/media URLs to frame-src Galleries do not yet work, they may need to be manually set in JS with a compiler or such
Each message has a gallery id of the index of the message. Each message should be its own gallery, so you can't accidentally page to a different messages attachments. Mirrors discord behavior.
khakers
force-pushed
the
feature/attachment-improvements
branch
from
22ad879
to
17dad52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves attachment support in Modmail-Viewer with a lightbox, better formatting, and a more discord like display for non media files.