fix: correct Ubuntu/macOS host_os detection via uname -s #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On older macOS versions (e.g., macOS 11),
uname -o
is unsupported (BSD uname lacks this GNU option). This causes host OS detection to fail.Additionally, the flash script inconsistently uses
uname -o
on Ubuntu, even thoughuname -s
is the more reliable method across platforms.Relative issue:
Solution
uname -s
(outputs Darwin) when -o is unavailable.uname -s
(outputs Linux) instead ofuname -o
(GNU/Linux) for consistency.