Added self-delegation functions in Customer Entity #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addinging self delegation can help adding extra logic before we set the variable. We can add the same extra logic in property set value too but it looks cleaner to have a separate function. For example, before setting email, we can check the format.
1 - Added Unique email rule violation exception catch and return null in case of violation 2 - Added email format validation rule checker
|
Would really love to get review as I am from embedded system domain and learning internet-based applications development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addinging self delegation can help adding extra logic before we set the variable.
We can add the same extra logic in property set value too but it looks cleaner to have a separate function.
For example, before setting email, we can check the format.