mod: upgrade go #10053
Merged
mod: upgrade go #10053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
github-actions
bot
added
keep pr updated
sam-heilbron
removed
the
work in progress
|
Visit the preview URL for this PR (updated for commit 071622e): https://gloo-edge--pr10053-sh-upgrade-go-9jeow2ox.web.app (expires Tue, 24 Sep 2024 00:59:50 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
tjons
approved these changes
Sep 17, 2024
sam-heilbron
commented
Sep 17, 2024
| @@ -0,0 +1,13 @@ | |||
| changelog: | |||
| - type: NON_USER_FACING | |||
| description: Upgrade kubernetes to 1.31 and go to 1.23.1 | |||
There was a problem hiding this comment.
bad copy/paste of changelog. i will cleanup in a follow-up
nfuden
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade Go to 1.23.1
Context
In solo-io#10026 we attempted to do this in one large PR. We hit issues with some tests, and the easiest way to get to the bottom of those failures is to breakdown the changes into smaller PRs and merge them independently.
Testing steps
Checklist: