-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yarrrml-star update #4
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments :)
mappings: | ||
person: | ||
subject: | ||
- quoted: student |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment here: either you introduce a new key, or you use the ~[specifier]
construct. I personally prefer - given you refer to a mapping in mapping
, quoted
, and unquoted
- the specifier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My question is, can both co-exist? and we treat ~[specifier]
as kind of shortcut?
Adding:
dist
todocs
folder for GitHub pages