-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use app router template #9186
base: v-next
Are you sure you want to change the base?
Use app router template #9186
Conversation
29477ea
to
19ab9c5
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f86b3fd:
|
@dcousens I will need some help in fixing tests,
@dcousens I have fixed most test cases, these tests definitely helped me fix a lot of issues. I see that document-field test can not be fixed due to static generation, I may have missed something. Test live-reloading.test is not behaving properly, same thing, trying to fix some page router vs app router thing. I am having trouble debugging locally on windows for some reason. |
@gautamsi I'm super busy and can't engage on this this week, but, I'll wrap back around as soon as I can and help move this forward 💛 |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Daniel Cousens <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
skip ui tests
f4cf9b7
to
f70d1fe
Compare
3794b1b
to
7f16a79
Compare
4a81dc4
to
00a6767
Compare
e075014
to
303b060
Compare
@dcousens I have not generated default files for all the example/test projects, have modified the code as such it will generate all the required nextjs files for dev and build. User would need to commit them in git. The file generation is one time except the |
isLiveReload: boolean | ||
) { | ||
// when we're not doing a live reload, we want to clear everything out except the .next directory (not the .next directory because it has caches) | ||
// so that at least every so often, we'll clear out anything that the deleting we do during live reloads doesn't (should just be directories) | ||
if (!isLiveReload) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part of live reload is not needed, we do not even need to figure out file linking from main dir to isolated dir anymore
ref #9183
Blocked by
This PR updates the template to generate the App router, default to typescript version which can be turned off by setting
config.ui.tsx = false
What is completed/Verified:
app/(admin)
folder (creates admin route specific layout page. ifsrc
page exist, it generates it in `src/app/(admin)next.config.js
file, this should be generated fromcreate-keystone-app
going forward (TODO)set defaultcan setui.basePath
to/admin
ui.basePath
to/admin
or any other sub path@fields/text/myView
)--reset-admin
flag todev
command to force clean(admin)
folder, useful in regenerate the admin template if updated in future. should never be needed except braking upgrade@keystone-6/auth
templatesPending:
@dcousens can you create a
v-next
branch which should be actual target for these PRs instead ofmain