-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge previous breaking changes #8776
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f0411da:
|
Rebased on |
@dcousens are there any dates set in stone for when the breaking release is coming? |
@mmachatschek no, but we are open to hear your feedback if you need it sooner than later. We know we want at least one more patch release to resolve #8784 before jumping to the next major. |
@dcousens we would like to give the RC a go if you guys could merge in the prisma 5.2 release |
@dcousens while working on an PR I found this code, https://github.com/keystonejs/keystone/blob/major/packages/core/src/lib/createSystem.ts#L133-L141 I guess this will also be removed in this breaking release? |
@mmachatschek I don't think |
@mmachatschek we're expected to have time to formally allocate to this soon (and other new features), early November. |
@dcousens any update on this? |
any plan to get this going (with latest prisma)? @dcousens |
@gautamsi I'm actively working on this, stay tuned for an |
Co-authored-by: Daniel Cousens <[email protected]>
…nds (#8698) Author: Pavel White <[email protected]> Date: Mon Aug 14 02:53:50 2023 +0300 Co-authored-by: Daniel Cousens <[email protected]>
This pull request includes the pull requests that were breaking from 2023, but had since been moved into a
major
branch.This is following some confusion that happened when we wanted to do an unexpected patch release last week and our
main
was polluted with breaking changes.We had hard reset
main
to the tag2023-08-15
(https://github.com/keystonejs/keystone/releases/tag/2023-08-15) and moved any breaking changes into this branch.We will use a
major
branch workflow in future, to support changes being easily tracked within the pull requests themselves.edit: Rebased pull requests listed below
keystone prisma ..
commands #8698--frozen
#8767