-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix execution unit tests on linux mint #2167
Fix execution unit tests on linux mint #2167
Conversation
🦋 Changeset is good to goLatest commit: 4169c83 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
}, | ||
"devDependencies": { | ||
"mongodb": "^3.3.3", | ||
"mongodb-memory-server": "^6.0.1" | ||
"mongodb": "^3.3.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a particular reason for moving this out of devDependencies
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, will fix it ASAP
This all looks good, as a final step could I get you to add a |
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I run unit tests on my local machine with linux mint v19.2 and all tests with mongodb adapter fails.
Turns out it was an error in package "mongodb-memory-server": typegoose/mongodb-memory-server#32
It was fixed in the version 6.1.0: https://github.com/nodkz/mongodb-memory-server/releases/tag/v6.1.0
In this PR I upgrade version of this package up to 6.1.1 to fix this