Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Clean up #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

lucas-aragno
Copy link

hey @keyserfaty !

I've made some changes to my fork since your last update here is the changelog:

  • I've added babel-plugin-transform-class-properties to the package json, if is not there webpack will fail b/c it's listed on the babel.rc
  • I've replaced _.map w/ the map function builted in ES6, and since we don't need lodash for now I've removed that dependency out ( see: https://www.sitepoint.com/lodash-features-replace-es6/)
  • I've also added the mapDispatchToProps function to the PostContainer.js since this is one of the best practices to deal w/ dispatch's
  • Also I think it's better to pass the props to the Post component individually than make them share the scope

I think that's all, feel free to reach me out for any feedback / modification that you may think could be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant