Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(web): refactor and harmonize constants 🏗️ #12072

Merged
merged 2 commits into from
Aug 6, 2024
Merged

refactor(web): refactor and harmonize constants 🏗️ #12072

merged 2 commits into from
Aug 6, 2024

Commits on Aug 1, 2024

  1. refactor(web): refactor and harmonize constants 

    Note that this adds the keyCodes > 50000 to `USVirtualKeyCodes`.

Fixes: #8146
    @ermshiperete
    ermshiperete committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    2c2acbe View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. refactor(web): don't include new ModifierKeyConstants in `modifierC… 

    …odes`

Keep `modifierCodes` as legacy API. This addresses a code review comment
(#12072 (comment)).
    @ermshiperete
    ermshiperete committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    66c74e0 View commit details
    Browse the repository at this point in the history