chore(web): improve auto-test references to globals in #11881 #11993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
mcdurdin
approved these changes
Jul 23, 2024
common/web/keyboard-processor/tests/dom/cases/domKeyboardLoader.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Marc Durdin <[email protected]>
The exports of the `util.ts` can now be imported as `@keymanapp/common-types/utils`. Those methods are used by developer. We still export the `Uni_IsSurrogate*` methods in `main.js` because they are needed by the keyboard-processor, but exporting everything would increase the size of the resulting `keymanweb.js`. Doing it this way keeps the size the same.
ermshiperete
merged commit 5552fdd
into
change/web/11878_remove-es5
18 of 19 checks passed
|
Oops - had pushed 5552fdd to the wrong branch... Doesn't matter, but muddles up this PR, sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider this a "patch PR" for #11881 - feel free to merge it early without my consent, as this is intended to fix issues I personally raised for that PR.
@keymanapp-test-bot skip