Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(windows): remove wm_keyman_keydown and wm_keyman_keyup #11920

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Jul 2, 2024

Also cleanup the use of state.msg as that had no relevant data in it.

Fixes: #11917

User Testing

  • TEST_WINDOWS: Please run a basic test of Windows functionality, verifying that Keyman operates as expected.

Also cleanup the use of state.msg as that had no relevant data in it.

Fixes: #11917
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Jul 2, 2024
@github-actions github-actions bot added windows/ windows/engine/ and removed user-test-required User tests have not been completed labels Jul 2, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Jul 2, 2024

User Test Results

Test specification and instructions

  • TEST_WINDOWS (PASSED): I tested this issue with the attached "keyman-18.0.67-alpha-test-11920" build on the Windows 10 & 11 OS environment: Here is my observation. (notes)

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S5 milestone Jul 2, 2024
Copy link
Contributor

@rc-swag rc-swag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@keymanapp-test-bot keymanapp-test-bot bot added the user-test-required User tests have not been completed label Jul 2, 2024
@dinakaranr
Copy link

Test Results

  • TEST_WINDOWS (passed): I tested this issue with the attached "keyman-18.0.67-alpha-test-11920" build on the Windows 10 & 11 OS environment: Here is my observation.
  1. Installed the "keyman-18.0.67.exe" file.
  2. Keyman keyboard added in the system tray.
  3. Open the keyman "Configuration" window.
  4. Installed and uninstalled keyboards on the "Keyboard Layouts" tab.
  5. Hotkeys works which is mentioned on the "Hotkeys" tab.
  6. Keyboard switched between languages by (Left-ALT + Shift)
  7. The keyboard works well in Notepad and libreoffice.
    The feature works well in Windows 10 & 11 OS environments. Thank you.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Jul 3, 2024
@mcdurdin mcdurdin merged commit f13f13b into master Jul 3, 2024
7 checks passed
@mcdurdin mcdurdin deleted the refactor/windows/11917-remove-wm_keyman_key branch July 3, 2024 20:58
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.68-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

chore(windows): eliminate wm_keymankeydown and wm_keymankeyup
4 participants