Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(developer): prevent invalid values in targets store #11918

Merged

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Jul 2, 2024

Fixes: #11773

@keymanapp-test-bot skip

@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Jul 2, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Jul 2, 2024

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S5 milestone Jul 2, 2024
@mcdurdin mcdurdin marked this pull request as ready for review July 5, 2024 04:37
@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-missing User tests have not yet been defined for the PR label Jul 5, 2024
@DavidLRowe
Copy link

Not super important, but if you're making changes in this area anyway...
Would you consider adding a warning for cases that are not wrong, but perhaps confusing? I'm thinking primarily of:

  • any windows macos linux web ... (where the user has checked all the boxes)

but maybe "any" plus another box would also fall in that category.

Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcdurdin
Copy link
Member Author

@DavidLRowe I've created #11996 for this but pushed it to a future release because I have no capacity to do it at present.

Base automatically changed from fix/developer/11814-kmx_u16-buffer-overrun to master July 23, 2024 05:17
@mcdurdin mcdurdin merged commit f0bac55 into master Jul 23, 2024
4 checks passed
@mcdurdin mcdurdin deleted the fix/developer/11773-prevent-invalid-targets-store-values branch July 23, 2024 07:44
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.73-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants