feat(common/models): support direct-child access for Trie node iteration 📚 #11869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
This was referenced Jun 25, 2024
mcdurdin
approved these changes
Jul 5, 2024
Comment on lines
+110
to
+117
| /* | ||
| Note: would otherwise return the current instance if `char == ''`. If | ||
| such a call is happening, it's probably indicative of an implementation | ||
| issue elsewhere - let's signal now in order to catch such stuff early. | ||
| */ | ||
| if(char == '') { | ||
| return undefined; | ||
| } |
There was a problem hiding this comment.
Do we want to log something like this?
There was a problem hiding this comment.
It's hard for the mobile apps to properly log console-logging statements made from the WebWorker. I don't know that it's worth the trouble when we don't already have a pattern established for capturing said logs.
| @@ -101,6 +105,38 @@ describe('Trie traversal abstractions', function() { | |||
| assert.isEmpty(eKeys); | |||
| }); | |||
|
|
|||
| it('direct traversal with simple internal nodes', function() { | |||
There was a problem hiding this comment.
The description is not very fluent -- ideally, should be something that works with "it", like:
Suggested change
| it('direct traversal with simple internal nodes', function() { | |
| it('directly traverses a trie model with simple internal nodes', function() { |
But this is a nit only, I don't really care that much
…sal-probs' into feat/common/models/direct-lexicon-traversal
Base automatically changed from
feat/common/models/lexicon-traversal-probs
to
master
July 8, 2024 07:37
|
Changes in this pull request will be available for download in Keyman version 18.0.70-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was originally part of #10973.
These changes will facilitate the next PR's changes (#11870), in which it becomes possible to support prediction, in full, solely via the
LexiconTraversaliterator structure.Note that this gives us a neat way to support new model types: if a
LexiconTraversalcan be defined for that model, we can efficiently search it and predict for it, even if it's not actually supported by a Trie! There would be no need for the model to define a separatepredictmethod on the model itself, as it can be implemented via the traversal.@keymanapp-test-bot skip