Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(developer): kmc generate #11014

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

feat(developer): kmc generate #11014

wants to merge 6 commits into from
+3,396 −19

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Mar 16, 2024 •
edited
Loading

INITIAL PHASE OF kmc generate

NEEDS REFACTOR BEFORE PUBLISH

This is a backup of the kmc generate work. Lots of TODOs

TODO:

@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Mar 16, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Mar 16, 2024 •
edited
Loading

User Test Results

Test specification and instructions

ERROR: user tests have not yet been defined

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the B17S4 milestone Mar 16, 2024
@mcdurdin mcdurdin force-pushed the feat/developer/kmc-generate branch 2 times, most recently from 3d22452 to 027ebfa Compare March 17, 2024 00:52
@mcdurdin mcdurdin modified the milestones: B17S4, B17S5 Mar 30, 2024
@darcywong00 darcywong00 modified the milestones: B17S5, B17S6 Apr 12, 2024
@darcywong00 darcywong00 modified the milestones: B17S6, A18S1 Apr 28, 2024
@darcywong00 darcywong00 modified the milestones: A18S1, A18S2 May 11, 2024
@mcdurdin mcdurdin modified the milestones: A18S2, A18S3 May 24, 2024
@mcdurdin mcdurdin modified the milestones: A18S3, A18S4 Jun 7, 2024
@darcywong00 darcywong00 modified the milestones: A18S4, A18S5 Jun 21, 2024
@mcdurdin
feat(developer): kmc-generate module
1ab9574 
Plenty of todo items left but this is a mostly-functional module for the
kmc generate command for automatically creating keyboard and model
projects.
@mcdurdin
feat(developer): kmc-generate docs and tests started
9003dbb
@mcdurdin
feat(developer): kmc generate cleanup
125cfe6 
Cleanup various todo items for kmc generate. Outstanding TODO item is
icon generation for .kmn.
@mcdurdin
feat(developer): unit tests for kmc-generate
a45abe4 
Note: these are more e2e than unit tests. It may be difficult to convert
them into solid unit tests due to the way that kmc-generate works based
on templates.
@mcdurdin mcdurdin force-pushed the feat/developer/kmc-generate branch from 5ccabea to a45abe4 Compare June 25, 2024 20:47
@mcdurdin mcdurdin mentioned this pull request Jun 30, 2024
Merged
@darcywong00 darcywong00 modified the milestones: A18S5, A18S6 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darcywong00 darcywong00 Awaiting requested review from darcywong00 darcywong00 will be requested when the pull request is marked ready for review darcywong00 is a code owner

@jahorton jahorton Awaiting requested review from jahorton jahorton will be requested when the pull request is marked ready for review jahorton is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
common/web/ common/ developer/compilers/ developer/ feat user-test-missing User tests have not yet been defined for the PR
Milestone
A18S6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcdurdin @darcywong00