[WIP] C++ port Proof of Concept #3
Draft
+2,900
−2,267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nekotekina
force-pushed
the
master
branch
4 times, most recently
from
b57afba to
78f83a5
Compare
Nekotekina
force-pushed
the
master
branch
20 times, most recently
from
1496ffb to
f50af0e
Compare
|
I haven't looked at the commits but in general I'm a fan of the idea of switching to C++. It doesn't look like upstream is willing to switch, so this would have to be done in a permanent fork. |
|
I don't really see any reason against. Maybe I was too rude after all. If it's memory usage on some embedded system, dynamic allocations in C++ only work in favor on C++. I have already significantly reduced static memory usage. Because with dynamic alloc you only pay more memory as your config grows bigger. |
Also allow includes to have non-.conf extensions.
Also split table to reduce memory size.
Use RTTI on listener socket.
Improve indicator on Wayland (resist forced changes). Optimize layer_indicator performance. Fix previous unnecessary LED setting. Compatible with previous settings because CAPS_LOCK equals 1. Based on pull-request initially proposed by @plague-spreader
Macro no longer allowes "words" (char sequences without delimiters). In order to write "Hello" it must be written as macro(H e l l o). Alternatively, it can be t(Hello) or type(Hello). Shell commands can't execute via `keyd do`. Example: macro(cmd(echo 1))
Also allow implicit layer creation on bindings.
Add leftctrl/leftsuper-alike key aliases. Allow ctrl as layer name equal to control. Allow multiname aliases in alias section.
Nekotekina
force-pushed
the
master
branch
6 times, most recently
from
0a1b768 to
4ee374b
Compare
Refactor config_backup class. Also use C++20 'using enum class'.
`keyd do` or `keyd bind` will copy user's credentials. Loaded .conf file will use keyd process credentials. Don't kill child processes in systemd config. Allow a train of IPC messages for optimization.
Remove full `*` wildcard support. Initially `m:*` was proposed by @jyn514 Additional wildcard `a:` to include abs pointer devices. When using `m:` those devices are excluded.
Nekotekina
force-pushed
the
master
branch
9 times, most recently
from
80e8208 to
5b5aa2d
Compare
These commands may be useful to execute at user session startup. User bindings are loaded by explicit calling `keyd reload` from user. User bindings are located at `~/.config/keyd/bindings.conf`.
Implement file_reader class (simple fd->container). Implement concat class for simple formatting strings. Some options allow significantly reduce executable size. Static part of libstdc++ now is only 130~150 Kb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not for merge.
Fixes issues with capslock indicator being reset (in Wayland, for example) (feel free to cherry-pick).
Fixes cursed issues with C fixed arrays by using C++ (partially).
The fact these issues exist is infuriating. Fixing this in pure C will only waste a lot of time.