Skip to content

Fix position counter in data generation#261

Draft
Copilot wants to merge 3 commits intoidg2from
copilot/check-data-generation-files
Draft

Fix position counter in data generation#261
Copilot wants to merge 3 commits intoidg2from
copilot/check-data-generation-files

Conversation

Copy link

Copilot AI commented Feb 3, 2026

Position counter was initialized to DATAGEN_NUM_RAND instead of 0, inflating reported position counts by the number of random opening moves (typically 12 per game). These opening moves are never written to the output PGN.

Changes

  • engine/main.cpp:70: Initialize plies to 0 instead of DATAGEN_NUM_RAND
// Before
int plies = DATAGEN_NUM_RAND;

// After  
int plies = 0;

This also corrects draw adjudication to trigger at 80 moves in the recorded game rather than 68.

Original prompt

Check over the files engine/main.cpp and runner.py for mistakes in the internal data generation process.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits February 3, 2026 21:44
Co-authored-by: kevlu8 <69993704+kevlu8@users.noreply.github.com>
Co-authored-by: kevlu8 <69993704+kevlu8@users.noreply.github.com>
Copilot AI changed the title [WIP] Check files for mistakes in internal data generation process Fix position counter in data generation Feb 3, 2026
Copilot AI requested a review from kevlu8 February 3, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants