This repository has been archived by the owner on May 1, 2024. It is now read-only.
Two fixes #47
Open
Two fixes #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ketanhwr
reviewed
Feb 21, 2018
| @@ -2325,8 +2325,8 @@ function drawLevelFinal() | |||
| drawRoundedRectangle(midx-120*(width/1220), midy, 100*(width/1220), 60*(width/1220), colorCheck, 4); | |||
| gameArena.shadowBlur = 0; | |||
| gameArena.font = "50px Zorque"; | |||
| gameArena.fillStyle = "#E6FFFF"; | |||
| gameArena.fillText("<",midx-143+70,midy-45+92); | |||
| gameArena.fillStyle = "#E6FFFF"; | |||
There was a problem hiding this comment.
You changed the indentation here. Kindly revert it back
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, my apologies that my editor (VS Code) took it upon itself to remove trailing spaces in levels.js:
#42
The only substantive change is in line 2329 which fixes the problem with the left and right arrows not lining up in the popup at the end of each level.
In about.js there was a problem for me with the bottom ray going through the last line of text. I've moved it down so that it is now between the two ships.