This repository has been archived by the owner on Apr 12, 2021. It is now read-only.
implemented up to 4 player mode #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request but #14 was made much more before, so I've proceeded with that 🙁 |
|
This seems like it would work, I'll do a review. |
ketanhwr
suggested changes
Dec 16, 2017
| turnCountBackup=0; | ||
| gameStarted = false; | ||
| round = 0; | ||
| playersEliminated = {red:false,green:false,blue:false,yellow:false}; |
There was a problem hiding this comment.
A little spacing would make code more easier to read as well as extend later on.
| } else { | ||
| $('#changePlayerError').stop().fadeIn(400).delay(2000).fadeOut(400); //fade out after 2 seconds | ||
| } | ||
|
|
|
|
||
| if(turnCount === 0) | ||
| { | ||
| if (!playersEliminated['red']) |
There was a problem hiding this comment.
Instead of passing 'red', 'blue', etc. you can create another array with all the color names, and just iterate from 0->3. This would easily allow adding more colors later on 🙂
| } | ||
| } | ||
| } | ||
|
|
||
| function resetTurnCount() { |
| { | ||
| turnCount = 0; | ||
| } | ||
| } |
| @@ -257,7 +393,7 @@ function updateMatrix() | |||
|
|
|||
| function checkGameOver() | |||
There was a problem hiding this comment.
Why did I repeat this function definition twice? Strange. I think you can remove it.
| @@ -290,28 +424,77 @@ function notStable() | |||
| return ans; | |||
| } | |||
|
|
|||
| // Next 2 Functions are used to undo elimination of players | |||
| function backUpCopyofPlayersEliminated() { | |||
There was a problem hiding this comment.
{ should start from next line in order to maintain consistency.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionality to play with up to 4 players added. Dropdown element added for player to select number of players.