Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phaser-sync #8

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

andrewjb123
Copy link
Contributor

Missing bits from phaser creature runtime put into kestrel runtime

Andrew Butkus and others added 2 commits November 23, 2017 23:54
Missing bits from phaser creature runtime put into kestrel runtime
Copy link
Owner

@kestrelm kestrelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

This change disables the loading of Anchor Points from the loaded JSON data. This does not sound like the correct thing to do. Also, there were some merge conflicts when this request was issued. Can you let me know what the main changes were so we can narrow them down for the merging. Thanks!

Copy link
Owner

@kestrelm kestrelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

The first change in the file does this:

+  /*
    // Load Anchor Points		    // Load Anchor Points
    if("anchor_points_items" in load_data)		    if("anchor_points_items" in load_data)
    {		    {
    	var anchor_point_base = load_data["anchor_points_items"];		    	var anchor_point_base = load_data["anchor_points_items"];
    	this.anchor_point_map = CreatureModuleUtils.FillAnchorPointMap(anchor_point_base);		    	this.anchor_point_map = CreatureModuleUtils.FillAnchorPointMap(anchor_point_base);
    }		    }
 +  */

It comments out the Loading of Anchor Points from the JSON data. Is this intentional? Because we still want to load Anchor Point data from the JSON. We should not comment out these lines since it seems incorrect to me.

Thanks

@andrewjb123
Copy link
Contributor Author

Hi,

I stupidly committed my changes when i was tired, i will go back and review this commit.

generally i think the main part which i added was

Creature.prototype.SetAnchorPoint =

which allows to set the anchorpoint dynamically (without needing to have it set in the json file)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants