Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): amend label filter after filter change #7536

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

yuri1969
Copy link
Contributor

What changes are being made and why?

Prevent the value of labels filter from being explicitly URI-encoded.

The issue might be related to #7404.

Steps to reproduce the issue

  1. Create the attached flow
  2. Execute the flow at least once
  3. Navigate to the Executions view
  4. Add the namespace is company.team filter
    Either:
  5. Click on the amp&:amp& label on the executions table
  6. Remove the namespace is company.team filter
    Or:
  7. Add the labels is amp&:amp& filter manually

The flow execution(s) gets filtered out completely. This is caused by the filter query getting URI-encoded to amp%2526 instead of amp%26.


How the changes have been QAed?

id: rat_157618
namespace: company.team

labels:
  amp&: amp& # '&' should be handled correctly

tasks:
  - id: hello
    type: io.kestra.plugin.core.log.Log
    message: Hello World! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To review
Development

Successfully merging this pull request may close these issues.

1 participant