Skip to content

Conversation

@wuruilong01
Copy link

No description provided.

Copy link
Owner

@kernelslacker kernelslacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loongarch bits look ok, the other bits should be broken out, with separate explanations/commits.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this part should be a separate diff.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separate diff.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separate diff, and some explanation why ?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separate diff too.

@wuruilong01
Copy link
Author

Other files have been fixed for bugs caused by SEGV and tested on LoongArch.

  • the used address to fill data should exist,otherwise trinity may get SEGV signal.
  • arg3type of vmsplice is ARG_IOVECLEN,if you modify it,you should also modify arg2 accordingly.

Sorry, I'm a beginner; perhaps fixing the errors should be done in the next submission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

None yet

2 participants