feat: split the "full" tree details data fetch into three separate queries#1770
Conversation
a4cbb69 to
40c3163
Compare
| status_code=HTTPStatus.OK, | ||
| ) | ||
|
|
||
| if len(rows) == 1: |
There was a problem hiding this comment.
can we really remove this condition?
There was a problem hiding this comment.
I see that in case a tree has a commit but no boots then it will just return boots: [] instead of {"error": "no boots for this tree"}. It seems like that doesn't make a difference to the dashboard since the pages are behaving the same as previously, and that kind of is the right response if we want to have the exact same return as before, so we actually can remove this condition
|
We'll hold this PR until the Grafana dashboard is available again, since it's currently broken due to changes in the deploy pipeline and we can't verify endpoint usage |
MarceloRobert
left a comment
There was a problem hiding this comment.
I checked the problem with the if len(rows) == 1 problem and left a reply, so there's not much else to be done. Pre-approving
40c3163 to
055ca50
Compare
Description
Split the "full" tree details data fetch into three separate, tab-specific queries (builds, boots, tests). Previously, a single heavy query fetched all builds, boots, and tests data at once after the summary loaded. Now each tab triggers only its own query when the user navigates to it, reducing unnecessary data transfer and backend load.
Changes
How to test