Phani/cli changes for pagination - #13
Merged
Merged
Conversation
![mesa-dot-dev[bot]](https://avatars.githubusercontent.com/in/1050077?s=60&v=4){kind=small}
There was a problem hiding this comment.
Performed full review of b0c753d...7997b8c
Tip
⚡ Quick Actions
This review was generated by Mesa.
Actions:
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
6 files reviewed | 5 comments | Review on Mesa | Edit Reviewer Settings
rgarcia
requested changes
Sep 9, 2025
rgarcia
reviewed
Sep 9, 2025
rgarcia
reviewed
Sep 9, 2025
masnwilliams
reviewed
Sep 9, 2025
masnwilliams
requested changes
Sep 9, 2025
masnwilliams
left a comment
masnwilliams
left a comment
Contributor
There was a problem hiding this comment.
read above comment ^^
rgarcia
reviewed
Sep 9, 2025
rgarcia
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Adds
--limitand--offsetflags to theapp historyanddeploy historycommands to support pagination.Why we made these changes
Commands that return a large number of items could be slow, consume too much memory, or hit API rate limits. Fetching results in pages provides a faster and more reliable user experience for users with many resources.
What changed?
cmd/app.go&cmd/deploy.go: Replaced the--allflag with--limit(default 100) and--offsetflags on theapp historyanddeploy historycommands.go.mod/go.sum: Bumped thekernel-go-sdkdependency tov0.11.1to support passing the new pagination parameters to the API.README.md: Updated documentation to reflect the new--limitflag, replacing--all.Description generated by Mesa. Update settings