bpf: add bpf_prog_run_data_pointers() #10260
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: 026bcf9 |
Author
|
Upstream branch: 3249e8a |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1022489=>bpf-next
branch
from
d301b8f to
f907d66
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
910d3ce to
50dc55d
Compare
Author
|
Upstream branch: f1d8c65 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1022489=>bpf-next
branch
from
f907d66 to
f39ed2d
Compare
Author
|
Upstream branch: f1d8c65 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1022489=>bpf-next
branch
from
f39ed2d to
531a54f
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
50dc55d to
f882b4c
Compare
Author
|
Upstream branch: 93ce3be |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1022489=>bpf-next
branch
from
531a54f to
a78269b
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
f882b4c to
4752827
Compare
syzbot found that cls_bpf_classify() is able to change tc_skb_cb(skb)->drop_reason triggering a warning in sk_skb_reason_drop(). WARNING: CPU: 0 PID: 5965 at net/core/skbuff.c:1192 __sk_skb_reason_drop net/core/skbuff.c:1189 [inline] WARNING: CPU: 0 PID: 5965 at net/core/skbuff.c:1192 sk_skb_reason_drop+0x76/0x170 net/core/skbuff.c:1214 struct tc_skb_cb has been added in commit ec624fe ("net/sched: Extend qdisc control block with tc control block"), which added a wrong interaction with db58ba4 ("bpf: wire in data and data_end for cls_act_bpf"). drop_reason was added later. Add bpf_prog_run_data_pointers() helper to save/restore the net_sched storage colliding with BPF data_meta/data_end. Fixes: ec624fe ("net/sched: Extend qdisc control block with tc control block") Reported-by: syzbot <[email protected]> Closes: https://lore.kernel.org/netdev/[email protected]/ Signed-off-by: Eric Dumazet <[email protected]> Cc: Paul Blakey <[email protected]> Reviewed-by: Victor Nogueira <[email protected]> Acked-by: Jamal Hadi Salim <[email protected]>
Author
|
Upstream branch: 93ce3be |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1022489=>bpf-next
branch
from
a78269b to
4fd5106
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1022489 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: add bpf_prog_run_data_pointers()
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1022489