selftests/bpf: fix list_del() in arena list #10020
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf[bot]](https://avatars.githubusercontent.com/u/70728002?s=80&v=4){kind=small}
|
Upstream branch: 48a97ff |
|
Upstream branch: 48a97ff |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1012896=>bpf-next
branch
from
1ac9d46 to
c14179c
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
2226789 to
3763655
Compare
|
Upstream branch: 48a97ff |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1012896=>bpf-next
branch
from
c14179c to
51ccbe9
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
3763655 to
47fa79c
Compare
|
Upstream branch: 50de48a |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1012896=>bpf-next
branch
from
51ccbe9 to
0af125f
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
47fa79c to
6d36951
Compare
The __list_del fuction doesn't set the previous node's next pointer to the next node of the node to be deleted. It just updates the local variable and not the actual pointer in the previous node. The test was passing up till now because the bpf code is doing bpf_free() after list_del and therfore reading head->first from the userspace will read all zeroes. But after arena_list_del() is finished, head->first should point to NULL; If you remove the bpf_free() call in arena_list_del(), the test will start crashing because now the userpsace will read 0x100 (LIST_POISON1) in head->first and segfault. Signed-off-by: Puranjay Mohan <[email protected]> Acked-by: Yonghong Song <[email protected]>
|
Upstream branch: 4f8543b |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1012896=>bpf-next
branch
from
0af125f to
24f8d3a
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
6d36951 to
6116807
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1012896 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: selftests/bpf: fix list_del() in arena list
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1012896