Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct <title> coordinates attribute name #1070

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

lfoppiano
Copy link
Collaborator

The attribute for the coordinates in titles is 'coord' instead of 'coords'.

I assume it was a typo, and it should be consistent with the rest of the TEI output, anyway it was easier to submit a PR than to ask first 😄

@lfoppiano lfoppiano requested a review from kermitt2 December 20, 2023 04:44
@coveralls
Copy link

coveralls commented Dec 20, 2023

Coverage Status

coverage: 39.946% (-0.01%) from 39.959%
when pulling 6eaa6f4 on bugfix/fix-coord-name-title
into 6bd974d on master.

@lfoppiano
Copy link
Collaborator Author

I also noticed that the title coordinates are not showing in the web interface, so I added it to the list in the Javascript file.

I also found that not all elements are present here, although this is for batch processing I suppose:

elementCoordinates = Arrays.asList("figure", "persName", "ref", "biblStruct", "formula", "s", "note");

@kermitt2
Copy link
Owner

Yes typo ! I found a couple others for <title> element :/

Also removed the p in grobid.js because it is for another PR.

@kermitt2 kermitt2 merged commit 4b77e73 into master Dec 21, 2023
1 of 3 checks passed
@kermitt2
Copy link
Owner

Thank you for the fix Luca !

@lfoppiano lfoppiano deleted the bugfix/fix-coord-name-title branch February 14, 2024 23:55
@lfoppiano lfoppiano added this to the 0.8.1 milestone Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants