-
Notifications
You must be signed in to change notification settings - Fork 19.6k
Fix the vocabulary_dtype
in keras.layers.IntegerLookup()
#21587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @ILCSFNO, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses an issue in the keras.layers.IntegerLookup()
layer by clarifying the supported data types for the vocabulary_dtype
parameter. The change updates the docstring to explicitly state that only int64
is currently supported, removing the previous suggestion that int32
was also an option. This ensures that the documentation accurately reflects the current implementation's capabilities, preventing potential confusion for users.
Highlights
- Documentation Update: Clarified that
keras.layers.IntegerLookup()
currently only supportsvocabulary_dtype='int64'
, updating the docstring to reflect this limitation and fix issue #21586.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the docstring for keras.layers.IntegerLookup
to clarify that only vocabulary_dtype='int64'
is currently supported. This is a helpful clarification for users. My review includes a suggestion to make this fix more robust by adding a validation check in the code to enforce this limitation, which would provide clearer and more immediate feedback to users if they attempt to use an unsupported dtype.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21587 +/- ##
=======================================
Coverage 82.73% 82.73%
=======================================
Files 567 567
Lines 56678 56678
Branches 8839 8839
=======================================
Hits 46895 46895
Misses 7609 7609
Partials 2174 2174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes #21586