Skip to content

Fix the vocabulary_dtype in keras.layers.IntegerLookup() #21587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2025

Conversation

ILCSFNO
Copy link
Contributor

@ILCSFNO ILCSFNO commented Aug 15, 2025

Fixes #21586

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @ILCSFNO, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue in the keras.layers.IntegerLookup() layer by clarifying the supported data types for the vocabulary_dtype parameter. The change updates the docstring to explicitly state that only int64 is currently supported, removing the previous suggestion that int32 was also an option. This ensures that the documentation accurately reflects the current implementation's capabilities, preventing potential confusion for users.

Highlights

  • Documentation Update: Clarified that keras.layers.IntegerLookup() currently only supports vocabulary_dtype='int64', updating the docstring to reflect this limitation and fix issue #21586.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the docstring for keras.layers.IntegerLookup to clarify that only vocabulary_dtype='int64' is currently supported. This is a helpful clarification for users. My review includes a suggestion to make this fix more robust by adding a validation check in the code to enforce this limitation, which would provide clearer and more immediate feedback to users if they attempt to use an unsupported dtype.

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.73%. Comparing base (45c98ec) to head (110a380).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21587   +/-   ##
=======================================
  Coverage   82.73%   82.73%           
=======================================
  Files         567      567           
  Lines       56678    56678           
  Branches     8839     8839           
=======================================
  Hits        46895    46895           
  Misses       7609     7609           
  Partials     2174     2174           
Flag Coverage Δ
keras 82.54% <ø> (ø)
keras-jax 63.64% <ø> (ø)
keras-numpy 58.22% <ø> (+<0.01%) ⬆️
keras-openvino 34.61% <ø> (ø)
keras-tensorflow 64.19% <ø> (ø)
keras-torch 63.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Aug 17, 2025
@fchollet fchollet merged commit 27504e6 into keras-team:master Aug 17, 2025
9 checks passed
@ILCSFNO ILCSFNO deleted the patch-1 branch August 20, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kokoro:force-run ready to pull Ready to be merged into the codebase size:XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the vocabulary_dtype in keras.layers.IntegerLookup()
4 participants