Version bump 3.11.2 and nnx fix #21565 #21570
Conversation
* Update operation.py * Update actions.yml * Update operation.py * Update actions.yml * Update operation.py * Update operation.py * Update operation.py * fix test * code reformat
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @laxmareddyp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on updating the Keras project version to 3.11.2. It also includes an important fix for the JAX backend, specifically addressing how state is initialized when NNX is enabled, ensuring better compatibility and stability. Additionally, a minor syntax error in an example within the operation.py file has been corrected.
Highlights
- Version Update: The Keras project version has been updated from 3.11.1 to 3.11.2, reflecting recent changes and preparing for new releases.
- JAX/NNX Integration Fix: A fix has been implemented in
keras/src/ops/operation.pyto improve compatibility with the JAX backend when NNX (Neural Networks eXtensions for JAX/Flax) is enabled. This involves a more resilient state initialization mechanism. - Syntax Correction: A small syntax correction was made in
keras/src/ops/operation.pyto fix an extraneous set of curly braces in aget_configmethod example.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request bumps the package version to 3.11.2 and includes a fix for compatibility with different versions of flax.nnx. My review focuses on improving the robustness of the nnx fix and correcting a formatting issue in an error message.
Specifically, I've suggested replacing a try-except block with hasattr checks for more explicit and safer version handling of the flax dependency. I also pointed out and suggested a fix for incorrect indentation in an example code snippet within an error message to improve its readability.
| try: | ||
| vars(instance)["_pytree__state"] = nnx.pytreelib.PytreeState() | ||
| except AttributeError: | ||
| vars(instance)["_object__state"] = nnx.object.ObjectState() |
There was a problem hiding this comment.
The use of a broad try...except AttributeError block can be brittle. It might catch an AttributeError from an unexpected source within the PytreeState() call, potentially masking other issues. A more explicit check for the existence of nnx.pytreelib.PytreeState using hasattr would be more robust and clearer about the intent, which is to handle different versions of the flax library.
| try: | |
| vars(instance)["_pytree__state"] = nnx.pytreelib.PytreeState() | |
| except AttributeError: | |
| vars(instance)["_object__state"] = nnx.object.ObjectState() | |
| if hasattr(nnx, "pytreelib") and hasattr(nnx.pytreelib, "PytreeState"): | |
| vars(instance)["_pytree__state"] = nnx.pytreelib.PytreeState() | |
| else: | |
| vars(instance)["_object__state"] = nnx.object.ObjectState() |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## r3.11 #21570 +/- ##
==========================================
- Coverage 82.72% 82.71% -0.01%
==========================================
Files 567 567
Lines 56264 56267 +3
Branches 8797 8797
==========================================
Hits 46544 46544
- Misses 7562 7565 +3
Partials 2158 2158
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
google-ml-butler
bot
added
kokoro:force-run
ready to pull
No description provided.