Changed the specification of MeanMetricWrapper

[MCCbena]

In the current specification, if no value is assigned to sample_weight, the masking process will not be performed and an inaccurate value may be output.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @MCCbena, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've addressed a bug in the MeanMetricWrapper where, if sample_weight was not explicitly provided, the masking process would be inadvertently skipped. This could lead to incorrect metric calculations. The change ensures that masking is consistently applied, regardless of whether sample_weight is present, thereby guaranteeing accurate metric outputs.

Highlights

• MeanMetricWrapper bug fix: Removed a conditional check (if sample_weight is not None and mask is not None:) in the update_state method of MeanMetricWrapper. This ensures that losses.loss.apply_mask is always called, preventing inaccurate metric calculations when sample_weight is None.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a bug in MeanMetricWrapper where an input mask would be ignored if sample_weight was not provided, leading to incorrect metric calculations. The change removes a conditional check, ensuring that losses.loss.apply_mask is always called to correctly process the mask. This fix is correct and robustly handles all cases of sample_weight and mask being present or absent. The implementation is sound and I have no suggestions for improvement.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.75%. Comparing base (04bc802) to head (16633a0).

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #21569   +/-   ##
=======================================
  Coverage   82.75%   82.75%           
=======================================
  Files         567      567           
  Lines       56471    56470    -1     
  Branches     8818     8817    -1     
=======================================
+ Hits        46730    46731    +1     
+ Misses       7580     7579    -1     
+ Partials     2161     2160    -1     

Flag	Coverage Δ
keras	82.56% <100.00%> (+<0.01%)	⬆️
keras-jax	63.78% <100.00%> (+<0.01%)	⬆️
keras-numpy	58.29% <100.00%> (+<0.01%)	⬆️
keras-openvino	34.67% <0.00%> (+<0.01%)	⬆️
keras-tensorflow	64.22% <100.00%> (+<0.01%)	⬆️
keras-torch	63.83% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.