Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement transform_bounding_boxes for random_shear #20704

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

shashaka
Copy link
Contributor

@shashaka shashaka commented Dec 31, 2024

I have implemented the transform_bounding_boxes method to support random shear functionality.

here is gist

@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 73.01587% with 17 lines in your changes missing coverage. Please review.

Project coverage is 81.93%. Comparing base (c8c2c6f) to head (4abd01a).

Files with missing lines Patch % Lines
.../preprocessing/image_preprocessing/random_shear.py 73.01% 14 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20704      +/-   ##
==========================================
- Coverage   81.94%   81.93%   -0.02%     
==========================================
  Files         548      548              
  Lines       51128    51190      +62     
  Branches     7906     7912       +6     
==========================================
+ Hits        41897    41942      +45     
- Misses       7296     7310      +14     
- Partials     1935     1938       +3     
Flag Coverage Δ
keras 81.76% <71.42%> (-0.02%) ⬇️
keras-jax 63.99% <68.25%> (+<0.01%) ⬆️
keras-numpy 58.93% <68.25%> (+0.01%) ⬆️
keras-openvino 29.86% <9.52%> (-0.03%) ⬇️
keras-tensorflow 64.68% <68.25%> (+<0.01%) ⬆️
keras-torch 64.06% <68.25%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thank you!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jan 2, 2025
@fchollet fchollet merged commit 5b29974 into keras-team:master Jan 2, 2025
9 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Jan 2, 2025
@shashaka shashaka deleted the random_shear branch January 2, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants