Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified example in depthwise_conv1d file #20268

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Modified example in depthwise_conv1d file #20268

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbb827c
Modified depthwise_conv1d.py example code
keerthanakadiri Sep 18, 2024
e2f6923
Modified example in depthwise_conv1d file
keerthanakadiri Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion keras/src/layers/convolutional/depthwise_conv1d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ class DepthwiseConv1D(BaseDepthwiseConv):
Example:

>>> x = np.random.rand(4, 10, 12)
>>> y = keras.layers.DepthwiseConv1D(3, 3, 2, activation='relu')(x)
>>> y = keras.layers.DepthwiseConv1D(kernel_size=3, depth_multiplier=3, strides=2, activation='relu')(x)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wouldn't work, it's lacking the filters argument

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fchollet ,
DepthwiseConv1D doesn't have filter arguments. If the filter argument is added then it's showing this error ValueError: Unrecognized keyword arguments passed to DepthwiseConv1D: {'filters': 16}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't pass the linter, every line should be below 80 characters. See below:
./keras/src/layers/convolutional/depthwise_conv1d.py:95:81: E501 line too long (108 > 80 characters)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ruidazeng,
Changed .Thank you for the suggestion !

>>> print(y.shape)
(4, 4, 36)
"""
Expand Down
Loading