-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: new landing page design (v2) #3739
Conversation
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
@thisisobate please check how you like the new graphics :) |
Signed-off-by: Moritz Wiesinger <[email protected]>
mobile version also needs some work still 😅 |
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple comments:
- could we change the text at the top, gradient on gradient is hard to read
- could we reduce the size of the CNCF logo, and use this one https://github.com/cncf/artwork/blob/main/other/cncf/horizontal/color-whitetext/cncf-color-whitetext.svg
oh yes, @mowies is taking a look at this. please note that this issue only applies to dark theme |
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
@thisisobate @nate-double-u we made some updates to dark mode, pls have a look one more time. We are happy with it now :) |
@thisisobate one more thing on mobile: it would be better to always have the text first and then have the picture below that. right now, it's always picture first, and then text |
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
Quality Gate passedIssues Measures |
I'm intrigued by your CI -- does the deploy preview automatically refresh? (I'm not seeing some of the changes that I'd expect to see based on the commits) |
(for instance, the CNCF logo still looks like the original one instead of the colour one that Uche updated) |
did you try disabling the cache? |
I'll try that -- but some things did update 😅 |
I see the updates now. I'm not sure about the AI generated images we're introducing. I don't think that they hold to the nautical theme that the project has historically had (I understand potentially wanting to move away from it, but if that's the case we're only partly moving away from it).
The lighthouse theming and icons on kptn.sh are pretty strong, I'd be hesitant to move away from them. Could we hold for a more thorough design review before merging this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold for design review
(notes above)
@nate-double-u I'd be glad to have better images! This is the best we could come up with as engineers 😅 |
I do like the looks of this! Thanks so much! I guess I don't really understand how the graphic for Metrics and Orchestrate relate to the theme but they are attractive and I, personally, like the cat ;-) A couple verbage and content-flow questions for your consideration. None of these are show-stoppers:
|
A bunch of those WARNINGs in the htmltest log sound ominous... You can search for "WARNING" in the log to see them quickly |
Hi @StackScribe |
@thisisobate shall we close this one in the meantime? |
sure...feel free |
New landing page design