Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP 91: Lifecycle Toolkit - Workload Information in KeptnApp #96

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thschue
Copy link
Contributor

@thschue thschue commented Feb 10, 2023

Signed-off-by: Thomas Schuetz [email protected]

Signed-off-by: Thomas Schuetz <[email protected]>
@malon875875
Copy link

This would greatly improve configuring Keptn LCT, so that not both Deployment manifest and KeptnApp Resource have to be modified any longer

@nlamirault
Copy link

Another improvment could be to specify which namespace to target. Like that:

apiVersion: keptn.sh/v1alpha1
kind: KeptnApp
metadata:
  name: my-app
  namespace: keptn
spec:
  version: 1.0.0
  workloads:
  - name: my-workload
    namespace: my-namespace
    version: 1.0.0
    selector:
      labelSelector:
        matchLabels:
          app: my-workload
          version: 1.0.0
    pre-deployment-tasks: my-pre-deployment-task (optional)
    post-deployment-tasks: my-post-deployment-task (optional)
    pre-deployment-evaluation: my-pre-deployment-evaluation (optional)
    post-deployment-evaluation: my-post-deployment-evaluation (optional)

@AnaMMedina21
Copy link
Member

With the comments on KEP92 [#97], could it just infer based on namespaces?

Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talking with @mowies, we believe this is not valid anymore since the KeptnApp is automagically created by the lifecycle operators watching annotations/labels on Workload level. Now users have to change only their K8s workload manifests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

5 participants