-
Notifications
You must be signed in to change notification settings - Fork 243
Fix broken 404 page on documentation website #2975 [ Issue resolved ] #659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you and congratulations 🎉 for opening your very first pull request in keploy
Signed-off-by: Amaan Mirza <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @amaan287 The Changes looks really amazing, also can you please redirect the user to the main docs page /docs/. Instead of just showing a 404 page
sure, can i add 5 second timer and a toast for better user experience ? |
Signed-off-by: amaan287 <[email protected]>
Added the redirect function and 2 second delay in redirect |
What has changed?
Please include a summary of the change.
This PR Resolves #2975(Fix broken 404 page on documentation website)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please run npm run build and npm run serve to check if the changes are working as expected. Please include screenshots of the output of both the commands. Add screenshots/gif of the changes if possible.
Checklist:
New "Not Found" Page
Old "Not Found" Page