fix: Default puppeteer-config to not set executable path unless OS is… #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… anything but Windows
… os test failure in github actions
|
🎉 This PR is included in version 1.10.0-alpha.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
keonik
added a commit
that referenced
this pull request
Aug 22, 2023
* feat: Configuration of Mermaid via .js file (#232) * feat: Enable override of mermaid configuration via a .js file * fix: Move theme to mermaid config and out of cli extensions * remove mermaid types stub * fix theme for readme erd * fix: Documentation for mermaid configuration and note about theme setting via env variable * feat: Add disable flag to prisma config options (#233) close issue #202 by adding an environment variable friendly approach to disabling the generator * fix: Default puppeteer-config to not set executable path unless OS is… (#235) * fix: Default puppeteer-config to not set executable path unless OS is anything but Windows * attempt to remove setting default executable path to troubleshoot mac os test failure in github actions * . * cross-env use for windows * fix: Move puppeteer args to arm64 darwin only
|
🎉 This PR is included in version 1.12.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… anything but Windows
closes #234