New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed minor bugs from unix.path #919

Open

ca20110820 wants to merge 1 commit into keon:master from ca20110820:fix_unix_path

ca20110820 commented Apr 14, 2024

Resolves minor bug seen from tests/test_unix.py under TestUnixPath.

The original implementation uses "{}/{}" which causes the bug when tested under Windows OS. I generalized it with:

os.path.join('{}', '{}')

without assuming the local machine's OS.

Changes

Fixed error from TestUnixPath.test_full_path method with os.path.join('{}', '{}').
Fixed unix.path.simplify_path.simplify_path_v1() function with posixpath.normpath() function.


          fix: fixed simplify_path_v1 using normpath from posixpath

93cca73

fix: updated expect_path from test_full_path method in test_unix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet