Skip to content

Commit

Permalink
reduce duplicates
Browse files Browse the repository at this point in the history
  • Loading branch information
kentSarmiento committed Dec 30, 2023
1 parent e813807 commit 83e9f3c
Showing 1 changed file with 5 additions and 17 deletions.
22 changes: 5 additions & 17 deletions link-for-later/src/service/links.rs
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,8 @@ impl LinksService for ServiceProvider {
id: &str,
link_item: &LinkItem,
) -> Result<LinkItem> {
let get_query = LinkQueryBuilder::default().id(id).build();
let retrieved_item = links_repo.get(&get_query).await?;

if link_item.owner() != retrieved_item.owner() {
return Err(AppError::Authorization(String::from(
"User is not authorized to access resource",
)));
}
let link_query = LinkQueryBuilder::new(id, link_item.owner()).build();
let retrieved_item = self.get(links_repo.clone(), &link_query).await?;

let now = Utc::now();
let updated_link_item = LinkItemBuilder::from(link_item.clone())
Expand All @@ -94,16 +88,10 @@ impl LinksService for ServiceProvider {
links_repo: Box<repository::DynLinks>,
link_item: &LinkItem,
) -> Result<()> {
let get_query = LinkQueryBuilder::default().id(link_item.id()).build();
let retrieved_item = links_repo.get(&get_query).await?;
let link_query = LinkQueryBuilder::new(link_item.id(), link_item.owner()).build();
self.get(links_repo.clone(), &link_query).await?;

if link_item.owner() == retrieved_item.owner() {
links_repo.delete(link_item).await
} else {
Err(AppError::Authorization(String::from(
"User is not authorized to access resource",
)))
}
links_repo.delete(link_item).await
}
}

Expand Down

0 comments on commit 83e9f3c

Please sign in to comment.