Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backend] New filesystem backend #812

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

andrewheberle
Copy link

This is a new backend that uses the filesystem as a KV store.

It adds a new config option max_file_size to limit the size of files it will read to avoid unbounded reads.

This defaults to 16KB, which may still be too high.

The value of the key is the content of the file, with leading and trailing whitespace removed.

Although not implemented, this probably should have a "prefix" value so that keys like "/myapp/database/url" could be relative to the "prefix" eg:

Prefix = /srv/config
Key = /myapp/database/url
Actual File Path = /srv/config/myapp/database/url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant