run one npx command at once on windows #432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyselden
reviewed
Nov 1, 2023
| if (os.platform() === 'win32') { | ||
| // running two npx commands in parallel on Windows causes it to break the npx cache | ||
| // folders and throw strange permissions errors. We need to run them in series | ||
| startCommand = await reset || init ? null : _prepareCommand(startOptions); |
There was a problem hiding this comment.
Can you put these in helper functions, so in both cases we just have prepareStart() and prepareEnd()?
kellyselden
reviewed
Nov 1, 2023
| let endCommand; | ||
|
|
||
| if (os.platform() === 'win32') { | ||
| // running two npx commands in parallel on Windows causes it to break the npx cache |
There was a problem hiding this comment.
Do you know if there's any way to get a failing test for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is taking @ef4's changes from ember-cli/ember-cli-update#1247 and actually submitting a PR here now that CI is fixed 🎉
Essentially ember-cli/ember-cli-update#1246 is blocked because you can't run two npx processes at the same time because they can clobber the disk cache in a way that causes strange permissions issues.
This PR essentially runs each npx command in series if you're running on windows 👍