Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Adding functionality to specify the slot order of items to drop. #154

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Pinibot
Copy link

@Pinibot Pinibot commented Apr 17, 2023

Fixes OSR-57

This can better mimic how humans drop from the inventory.

Added this functionality to the sample woodcutter bot.

@NiceTryGuyPython
Copy link

I love the click order variations, those are so great. I find the concept of misclicking is lacking because it just doesn't click at all if the criteria is met, so it effectively never actually "misclicks". It just skips a value from time to time.

@Pinibot
Copy link
Author

Pinibot commented Apr 18, 2023

I love the click order variations, those are so great. I find the concept of misclicking is lacking because it just doesn't click at all if the criteria is met, so it effectively never actually "misclicks". It just skips a value from time to time.

That's a fair point, cheers for the feedback. I'll remove the misclick code and raise a new pr for that in the future after rethinking it

@Pinibot
Copy link
Author

Pinibot commented Apr 19, 2023

@NiceTryGuyPython Added misclick functionality back with 3 different misclick types: fail to click (as before), accidental drag, click on empty space between items

@kelltom
Copy link
Owner

kelltom commented Apr 22, 2023

Any chance we can get some demo videos in here of some variations?

@kelltom kelltom added the type: enhancement This issue or pull request enhances existing code label Apr 22, 2023
@Pinibot
Copy link
Author

Pinibot commented Apr 23, 2023

@kelltom Added imgur links to the comments that demo behaviour. Note that some of these also show examples of the misclicks

HORIZONTAL: https://imgur.com/CksPmKe
HORIZONTAL_ALTERNATING: https://imgur.com/GWKZixY
VERTICAL: https://imgur.com/R42mEcg
VERTICAL_ALTERNATING: https://imgur.com/oorxfE2

src/model/bot.py Outdated Show resolved Hide resolved
This can better mimic how humans drop from the inventory.
Also added an optional chance of misclicking when dropping an item
which is more human-like. The missed item(s) will be reattempted once
all other slots to drop have been attempted.

Added this functionality to the sample woodcutter bot.
…ething smarter than just missing a click"

This reverts commit 375c573.
@kelltom
Copy link
Owner

kelltom commented Apr 27, 2023

Awesome, love it. Thanks for sharing the Imgur links too.

I'm gonna take a look this weekend!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement This issue or pull request enhances existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants