Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slimeread: Fix apiurl #6695

Closed
wants to merge 2 commits into from
Closed

Slimeread: Fix apiurl #6695

wants to merge 2 commits into from

Conversation

Hellkaros
Copy link
Contributor

@Hellkaros Hellkaros commented Dec 19, 2024

Closes #6673

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension

@Smol-Ame

This comment was marked as resolved.

@vetleledaal vetleledaal added the Geo-blocked Only available in specific regions label Dec 21, 2024
@euxande
Copy link

euxande commented Dec 21, 2024

Eu sou novo com essa coisa de programação. Onde eu coloco esses códigos pra poder executar o slimeread?

@Hellkaros

This comment was marked as off-topic.

@vetleledaal

This comment was marked as resolved.

@choppeh
Copy link
Contributor

choppeh commented Dec 23, 2024

@MrRobotCoder I had to make changes in the same place in SlimeRead to include another source. 😔🙏 PR: #6780

@Hellkaros
Copy link
Contributor Author

Hellkaros commented Dec 23, 2024

No problem @choppeh your change to the apiurl is great... I'll close this PR since yours is more complete and automatically retrieves the URL within the script. Can you just push another commit to the build.gradle changing the overrideVersionCode from 15 to 16?

Since I think choppeh's solution is better implemented, I'm closing this PR.

@Hellkaros Hellkaros closed this Dec 23, 2024
@Hellkaros Hellkaros deleted the slimeread branch December 23, 2024 22:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Geo-blocked Only available in specific regions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SlimeRead (PT-BR Source) Could not find API URL.
5 participants