Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ReadChainsawManMangaOnline extension #6665

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

babrums
Copy link

@babrums babrums commented Dec 18, 2024

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension

No issues while testing on Google Pixel Tablet and Google Pixel 8

However, faced strange bug while testing on emulated device in Android Studio: all images in title "Listen to Song" single chapter are distorted. Screenshot is on the discord server

@babrums
Copy link
Author

babrums commented Dec 18, 2024

Glitched images occurred while testing on emulated Pixel 6 API 35 (Android 15.0) in "Just Listen to the Song"

@@ -2,8 +2,9 @@ ext {
extName = 'Read Chainsaw Man Manga Online'
extClass = '.ReadChainsawManMangaOnline'
themePkg = 'mangacatalog'
baseUrl = 'https://ww1.readchainsawman.com'
overrideVersionCode = 0
baseUrl = 'https://ww4.readchainsawman.com/'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add trailing slash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants