Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asura Scans: support high quality chapter images #6657

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

vetleledaal
Copy link
Contributor

Might be patched in the future, so disabling it by default.

Have not fully considered how caching will be affected by this. User might expect chapters in the cache to be invalidated, but if that is not a concern it should be fine.

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension

@AwkwardPeak7
Copy link
Contributor

this conversion doesn't seem to work for me, it gives 404 and redirects to their admin page(?)
image

@vetleledaal vetleledaal marked this pull request as draft December 18, 2024 06:33
@vetleledaal
Copy link
Contributor Author

The issue was that it was trying to rewrite cover URLs as well. Added a fragment for all chapter images so it can be identified in the interceptor.

The logic will be disabled if any 404 is seen during the URL rewrite, as this means a previous assumption is broken. I tried to provide feedback via toast, but that broke the images completely. Instead, additional text was added to the extension settings.

@vetleledaal vetleledaal marked this pull request as ready for review December 18, 2024 21:05
@AwkwardPeak7 AwkwardPeak7 merged commit 4db5330 into keiyoushi:main Dec 19, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants