Solutions #181
Open
Solutions #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solution refactors `cat_generator` into a glue between two responsibilities: generating a name and generating a birthday.
When we gave this tutorial at Pycon 2016, some of the students found the solution confusing since it uses parameterized fixtures, which at this point in the tutorial we have not introduced. I have kept the parameterized fixtures around so that we can refer to them in step 7 on parameterization.
Added tests that provide full coverage for the is leap year algorithm. The rules seem pretty arbitrary but I referred to the wikipedia article for more clarity: https://en.wikipedia.org/wiki/Leap_year#Gregorian_calendar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.